D16942: CMakeCacheModel: avoid string memory duplication
Milian Wolff
noreply at phabricator.kde.org
Sun Nov 18 19:55:24 GMT 2018
mwolff added inline comments.
INLINE COMMENTS
> cmakecachemodel.cpp:76
> + line.remove(0, 2);
> + currentComment += line;
> + } else if(!line.isEmpty() && !line.startsWith(QLatin1Char('#'))) //it is a variable
would be easier to just write
currentComment += line.midRef(2);
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D16942
To: dakon, brauch
Cc: mwolff, brauch, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181118/89028478/attachment.html>
More information about the KDevelop-devel
mailing list