D16218: [KDevelop/Core]: safe signal-handler implementation

[Aaron Puchert]

aaronpuchert added a comment.


  In D16218#346296 <https://phabricator.kde.org/D16218#346296>, @rjvbb wrote:
  
  > > Maybe you can add an else branch where you re-raise the signal with the default handler.
  >
  > If the goal is just to let a 2nd signal trigger the default reaction from the runtime then it can be even simpler.
  
  
  The goal would be to handle the case `signalPipeWrite == -1`. Although I'm actually not sure why we need to check that in the first place, because you register the signal handler only //after// creating the pipe has succeeded. Then `signalPipeWrite != -1` should be a given, but you could add an assertion (when creating the pipe) if you want.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16218

To: rjvbb, #kdevelop, kfunk, aaronpuchert
Cc: aaronpuchert, brauch, kfunk, arrowd, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181114/af4202fe/attachment-0001.html>