D11136: Make sure we use the same compiler settings as the project is by default
noreply at phabricator.kde.org
Wed Mar 14 17:47:25 UTC 2018
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
stylistic wise a clear +1, conceptually I still fear this is going to break a lot of things - but not due to your code, but rather due to the broken GCC compatibility in clang. I think we can get this in and then we need to figure out how to handle the clang/gcc compatibility story somehow else... I don't know how, nor do I have time to investigate right now :(
Can you just do me one favor please, before you merge: Can you try KDevelop with this patch on a non-cross-compiled CMake project where you use GCC instead of clang for compiling? Does KDevelop work fine in its current form with a recent clang/gcc - or does it break in some horrible ways? If it's OK then I'd say let's merge this. If everything breaks... I fear we need to figure out a workaround first before introducing the breakage to everyone :(
To: apol, #kdevelop, mwolff
Cc: aaronpuchert, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel