D11291: Do not add return type to constructors declaration when editing definition in signature assistant.

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> mwolff wrote in adaptsignatureassistant.cpp:49
> afaik you can simplify the below by reusing a function from DUChainUtils that gets you the declaration for a definition. always cast that at the start and then cast the return result

bool isConstructor(const Declaration *functionDecl)
  {
      auto classFun = dynamic_cast<const ClassFunctionDeclaration*>(DUChainUtils::declarationForDefinition(functionDecl));
      return classFun && classFun->isConstructor();
  }

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D11291

To: shashwatdixit, kfunk, mwolff, #kdevelop, brauch
Cc: brauch, apol, #kdevelop, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180314/87247bdb/attachment-0001.html>