D13537: Fix definesandincludes test.

Gleb Popov noreply at phabricator.kde.org
Thu Jun 14 12:52:34 UTC 2018


arrowdodger created this revision.
arrowdodger added reviewers: KDevelop, skalinichev.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
arrowdodger requested review of this revision.

REVISION SUMMARY
  The code as it currently stands do not return any parser arguments for any `LanguageType::Other` files.
  The checks I removed were added for this commit: https://phabricator.kde.org/R32:1c78a564626a0e5e305383c5fdb36b0fc76073cc
  However, I can't find it in the history:  https://phabricator.kde.org/source/kdevelop/history/master/plugins/custom-definesandincludes/definesandincludesmanager.cpp
  I suspect it wasn't merged properly and got lost.
  
  Anyway, now `parserArguments` tries to guess language type for a file requested and for `ProjectFolderItem` `LanguageType::Other` is returned.

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13537

AFFECTED FILES
  plugins/custom-definesandincludes/tests/test_definesandincludes.cpp

To: arrowdodger, #kdevelop, skalinichev
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180614/4dd23ee6/attachment.html>


More information about the KDevelop-devel mailing list