<table><tr><td style="">arrowdodger created this revision.<br />arrowdodger added reviewers: KDevelop, skalinichev.<br />Restricted Application added a project: KDevelop.<br />Restricted Application added a subscriber: kdevelop-devel.<br />arrowdodger requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13537">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The code as it currently stands do not return any parser arguments for any <tt style="background: #ebebeb; font-size: 13px;">LanguageType::Other</tt> files.<br />
The checks I removed were added for this commit: <a href="https://phabricator.kde.org/R32:1c78a564626a0e5e305383c5fdb36b0fc76073cc" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/R32:1c78a564626a0e5e305383c5fdb36b0fc76073cc</a><br />
However, I can't find it in the history:  <a href="https://phabricator.kde.org/source/kdevelop/history/master/plugins/custom-definesandincludes/definesandincludesmanager.cpp" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/source/kdevelop/history/master/plugins/custom-definesandincludes/definesandincludesmanager.cpp</a><br />
I suspect it wasn't merged properly and got lost.</p>

<p>Anyway, now <tt style="background: #ebebeb; font-size: 13px;">parserArguments</tt> tries to guess language type for a file requested and for <tt style="background: #ebebeb; font-size: 13px;">ProjectFolderItem</tt> <tt style="background: #ebebeb; font-size: 13px;">LanguageType::Other</tt> is returned.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13537">https://phabricator.kde.org/D13537</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/custom-definesandincludes/tests/test_definesandincludes.cpp</div></div></div><br /><div><strong>To: </strong>arrowdodger, KDevelop, skalinichev<br /><strong>Cc: </strong>kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>