D13313: Fix using reserved type names in identifiers.
noreply at phabricator.kde.org
Sun Jun 3 19:41:18 UTC 2018
pprkut created this revision.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
pprkut requested review of this revision.
Remove special tokens for base type names (PHP itself doesn't
have them either in their AST). Unfortunately, keeping them,
while cleaner, is also a lot more complicated and would leave
us with double the amount of FIRST/FIRST conflicts in the grammar.
(Mostly when NamespacedIdentifiers would conflict with base types
in typehints. Think 'String\Stringhandler $foo' vs 'string $bar'.
Removing the tokens essentially immediately resolves the bug,
with the remaining work just being error handling and a bit of
R52 KDevelop: PHP Support
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel