D13313: Fix using reserved type names in identifiers.

[Heinz Wiesinger]

pprkut created this revision.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
pprkut requested review of this revision.

REVISION SUMMARY
  Remove special tokens for base type names (PHP itself doesn't
  have them either in their AST). Unfortunately, keeping them,
  while cleaner, is also a lot more complicated and would leave
  us with double the amount of FIRST/FIRST conflicts in the grammar.
  (Mostly when NamespacedIdentifiers would conflict with base types
  in typehints. Think 'String\Stringhandler $foo' vs 'string $bar'.
  
  Removing the tokens essentially immediately resolves the bug,
  with the remaining work just being error handling and a bit of
  cleanup.
  
  BUG: 392759

REPOSITORY
  R52 KDevelop: PHP Support

BRANCH
  types2

REVISION DETAIL
  https://phabricator.kde.org/D13313

AFFECTED FILES
  completion/context.cpp
  duchain/builders/declarationbuilder.cpp
  duchain/builders/declarationbuilder.h
  duchain/builders/usebuilder.cpp
  duchain/expressionvisitor.cpp
  duchain/helper.cpp
  duchain/helper.h
  duchain/tests/duchain.cpp
  duchain/tests/duchain.h
  parser/php.g
  parser/phplexer.cpp
  parser/test/lexertest.cpp

To: pprkut
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180603/b055e917/attachment.html>