D12527: Remove reimplementation of PartDocument:close() in TextDocument

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D12527#300105 <https://phabricator.kde.org/D12527#300105>, @kossebau wrote:
  
  > Looking at it, why the test fails is clear, Sublime::View destructor only deletes the widget with deleteLater(), so without any DeferredDelete event handler between the widget is still there, other than what the test expects.
  
  
  Looking at the history, I could not find any reason for the deferred delete of the widget. . Assuming defensive programming at that time, or perhaps some related issues with ktexteditor.
  Running kdevelop now the next days with the actual widget deleted in sync, so far no issues hit.
  So currently my favourite. Might also remove the need for the delayed mainwindow wrapper destruction again. Let's see :) Would be good to gain more control about destruction timing by that.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D12527

To: croick, #kdevelop, kossebau
Cc: kossebau, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180729/c6ae1bcd/attachment.html>