D13580: Add support for Generators.

[Alexander Zhigalin]

zhigalin added subscribers: brauch, kfunk, mwolff, zhigalin.
zhigalin removed a reviewer: KDevelop.
zhigalin accepted this revision as: zhigalin.
zhigalin added a comment.
This revision is now accepted and ready to land.


  Hello.
  Sorry for the late reply, I haven't noticed when this review was created
  
  > This adds support for generators and generator delegation
  
  This is great, with this patch the [T6816: PHP 5.5 features <https://phabricator.kde.org/T6816>] will be fully supported!
  The path looks good to me.
  
  (NOTE) P.S. the KDE admins have deliberately decided to remove projects from reviewers and leave only mailing list as subscription
  so  you shouldn't add them manually.
  
  If you want to attract attention simply write **ping** in the comments.
  Fell free to do it more frequently, it have been here for more than 1 month and I totally missed it.
  
  /CC @mwolff @kfunk @brauch

INLINE COMMENTS

> phplexer.cpp:810-811
> +                }
> +                if (pos + 1 < m_contentSize && lookAhead->unicode() == 'f' && (++lookAhead)->unicode() == 'r' &&
> +                     (++lookAhead)->unicode() == 'o' && (++lookAhead)->unicode() == 'm') {
> +                    m_curpos = pos + 4;

This smells like spaghetti, are you sure? how about something like

  auto nextToken = QString();
  nextToken += *   lookAhead;
  nextToken += * ++lookAhead;
  nextToken += * ++lookAhead;
  nextToken += * ++lookAhead;
  if (pos + 1 < m_contentSize && nextToken == QStringLiteral("from")) {

//(example code, not sure it will work)//

REPOSITORY
  R52 KDevelop: PHP Support

BRANCH
  generators

REVISION DETAIL
  https://phabricator.kde.org/D13580

To: pprkut, zhigalin, #kdevelop
Cc: zhigalin, mwolff, kfunk, brauch, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180729/9b74e041/attachment.html>