<table><tr><td style="">zhigalin added subscribers: brauch, kfunk, mwolff, zhigalin.<br />zhigalin removed a reviewer: KDevelop.<br />zhigalin accepted this revision as: zhigalin.<br />zhigalin added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13580">View Revision</a></tr></table><br /><div><div><p>Hello.<br />
Sorry for the late reply, I haven't noticed when this review was created</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>This adds support for generators and generator delegation</p></blockquote>
<p>This is great, with this patch the [<a href="https://phabricator.kde.org/T6816" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T6816: PHP 5.5 features</a>] will be fully supported!<br />
The path looks good to me.</p>
<div style="margin: 16px 0;
padding: 12px;
border-left: 3px solid #2980b9;
background: #daeaf3;">P.S. the KDE admins have deliberately decided to remove projects from reviewers and leave only mailing list as subscription
so you shouldn't add them manually.</div>
<p>If you want to attract attention simply write <strong>ping</strong> in the comments.<br />
Fell free to do it more frequently, it have been here for more than 1 month and I totally missed it.</p>
<p>/CC <a href="https://phabricator.kde.org/p/mwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mwolff</a> <a href="https://phabricator.kde.org/p/kfunk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kfunk</a> <a href="https://phabricator.kde.org/p/brauch/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@brauch</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13580#inline-76166">View Inline</a><span style="color: #4b4d51; font-weight: bold;">phplexer.cpp:810-811</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">pos</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span> <span style="color: #aa2211"><</span> <span class="n">m_contentSize</span> <span style="color: #aa2211">&&</span> <span class="n">lookAhead</span><span style="color: #aa2211">-></span><span class="n">unicode</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'f'</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span style="color: #aa2211">++</span><span class="n">lookAhead</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">unicode</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'r'</span> <span style="color: #aa2211">&&</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">(</span><span style="color: #aa2211">++</span><span class="n">lookAhead</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">unicode</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'o'</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span style="color: #aa2211">++</span><span class="n">lookAhead</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">unicode</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'m'</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_curpos</span> <span style="color: #aa2211">=</span> <span class="n">pos</span> <span style="color: #aa2211">+</span> <span style="color: #601200">4</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This smells like spaghetti, are you sure? how about something like</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">auto nextToken = QString();
nextToken += * lookAhead;
nextToken += * ++lookAhead;
nextToken += * ++lookAhead;
nextToken += * ++lookAhead;
if (pos + 1 < m_contentSize && nextToken == QStringLiteral("from")) {</pre></div>
<p style="padding: 0; margin: 8px;"><em>(example code, not sure it will work)</em></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R52 KDevelop: PHP Support</div></div></div><br /><div><strong>BRANCH</strong><div><div>generators</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13580">https://phabricator.kde.org/D13580</a></div></div><br /><div><strong>To: </strong>pprkut, zhigalin, KDevelop<br /><strong>Cc: </strong>zhigalin, mwolff, kfunk, brauch, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>