D14376: kdev-clang : avoid crash in tests/test_assistants.cpp

[Friedrich W. H. Kossebau]

kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.


  > This patch prevents crashing when that happens, but is it the most appropriate fix?
  
  What is your own answer to this? ;)
  
  Surely there must be something wrong in the internal logic, given that TestBed class seems to try to wrap an instance of a document.  Please try to investigate why the document is not returned from the controller as one would expect by the code.
  
  Sadly for me locally the tests fails for other reasons, so I cannot give you some results to compare for. CI at least for stable on openSUSE also does not show crashes, only other issues.
  
  This patch just puts a cover over any potential issues, not good. We should know whether to expect from the documentcontroller to return a document for the given url. Please consider to help by investigating this more deeply.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14376

To: rjvbb, kossebau
Cc: kossebau, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180725/eb023071/attachment-0001.html>