D14376: kdev-clang : avoid crash in tests/test_assistants.cpp
René J.V. Bertin
noreply at phabricator.kde.org
Wed Jul 25 16:32:21 BST 2018
rjvbb created this revision.
rjvbb added a project: KDevelop.
rjvbb requested review of this revision.
REVISION SUMMARY
`Core::self()->documentController()->documentForUrl(url)` can return a nullptr and apparently does so reliably when running the plugins/clang/tests/test_assistants test on Mac.
This patch prevents crashing when that happens, but is it the most appropriate fix?
TEST PLAN
without the patch: crash (on Mac)
with the patch: no crash.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D14376
AFFECTED FILES
plugins/clang/tests/test_assistants.cpp
To: rjvbb
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180725/6354f386/attachment.html>
More information about the KDevelop-devel
mailing list