D14337: Fix GdbTest::testUpdateBreakpoint from messed-up break points positions
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Jul 24 18:00:47 BST 2018
kossebau added a subscriber: arrowd.
kossebau added a comment.
In R32:e4b139268ccf9be93b0049c503d4caab6241b4ec#3677576 <https://phabricator.kde.org/R32:e4b139268ccf9be93b0049c503d4caab6241b4ec#3677576>, @arrowd wrote:
> @kossebau I think it is a nice idea to include the line you intend to break on in the comments. I did the same in https://phabricator.kde.org/R32:6c253502d22a85a135ae131ab86bbae33b4b78e3 and hope this would reduce further breakage.
Yes, considered as well, but for some reason dropped it again (the double `foo();` line made this ambiguous and made me unhappy about the approach).
For some moments wondered if I should not add comments with tags to the actual debugged code which then gets parsed to derive the real line number).
Let's see if I get to solve the other tests falling on CI for this test currently tonight (sadly not for me), might give it a try, otherwise just add comments as you proposed.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D14337
To: kossebau, #kdevelop
Cc: arrowd, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180724/06a0c55b/attachment-0001.html>
More information about the KDevelop-devel
mailing list