D14337: Fix GdbTest::testUpdateBreakpoint from messed-up break points positions

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Commit e4b139268ccf9be93b0049c503d4caab6241b4ec <https://phabricator.kde.org/R32:e4b139268ccf9be93b0049c503d4caab6241b4ec> added some lines to the
  sources of the debugged code, but only updated the first breakpoint
  position, with the second manually inserted suddenly being before the
  first.
  This results in a race condition, given the command for the
  second breakpoint is only executed when the actual program is also run
  and might have already reached the originally set breakpoint. In that case
  the manually set breakpoint no longer will be reached, breaking the
  assumptions of the test case.
  
  Remove also extra session->stepInto(); which served no obvious purpose
  for the given test case.

REPOSITORY
  R32 KDevelop

BRANCH
  fixtestUpdateBreakpoint

REVISION DETAIL
  https://phabricator.kde.org/D14337

AFFECTED FILES
  plugins/gdb/unittests/test_gdb.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180724/85452459/attachment.html>