D14212: Enable warnings zero-as-null-pointer-constant & suggest-override

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> aaronpuchert wrote in CMakeLists.txt:147
> If `-Winconsistent-missing-override` is on by default, there is nothing you need to do. (I haven't seen the warning for third-party code, so disabling it might also not be necessary.)

Okay, could also not see any traces for such warnings with freebsd clang builds on CI.
So I leave inconsistent-missing-override out for now then, can be still added by those using clang if needed :)

> kossebau wrote in CMakeLists.txt:10-11
> Agreed, had the same idea. Though for now I was lazy and just copied the approach done for the -Wdocumentation flag.  Left that improvement though for a latter separate patch, until the flag addition in general are accepted.

After I had experimentally added support for -Winconsistent-missing-override and its inversion, I found being able to drop any version checks would be nice to have already now, so went and extended the macro side of things.

As I am not sure if one can rely on the "no-" version to be present for a flag, I simply have gone to propose testing the actual flag to be used to be present, so we are on the safe side.

REPOSITORY
  R32 KDevelop

BRANCH
  addnullptroverridewarnings

REVISION DETAIL
  https://phabricator.kde.org/D14212

To: kossebau, #kdevelop, aaronpuchert
Cc: aaronpuchert, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180723/57bdd146/attachment.html>