D14212: Enable warnings zero-as-null-pointer-constant & suggest-override

[Aaron Puchert]

aaronpuchert added inline comments.

INLINE COMMENTS

> kossebau wrote in CMakeLists.txt:147
> The docs say the diagnostic "-Winconsistent-missing-override" is "enabled by default.":
> https://clang.llvm.org/docs/DiagnosticsReference.html#winconsistent-missing-override
> 
> Other places claim it is part of "-Wall" at least since clang 3.5, but I could not find anything related in the release notes, so far unsure when this was added and when per default enabled.
> 
> So would you think it is still needed here to try to enable it as well?
> 
> I would assume disabling it for the 3rd-party makes sense still.

If `-Winconsistent-missing-override` is on by default, there is nothing you need to do. (I haven't seen the warning for third-party code, so disabling it might also not be necessary.)

REPOSITORY
  R32 KDevelop

BRANCH
  addnullptroverridewarnings

REVISION DETAIL
  https://phabricator.kde.org/D14212

To: kossebau, #kdevelop, aaronpuchert
Cc: aaronpuchert, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180723/9cdc3b69/attachment.html>