D14113: Reschedule parse jobs also when the parse queue is empty.

[Heinz Wiesinger]

pprkut created this revision.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
pprkut requested review of this revision.

REVISION SUMMARY
  I assume the original assumption here was that when the parse
  queue is empty, scheduling another re-parse of the current file
  doesn't make sense as we already have access to all parsed
  declarations.
  
  However, I don't think this assumption holds, especially in a
  multi-core environment. The unit tests covering this code were
  failing because the two test files were parsed at the same time,
  resulting in the declarations being not yet available and the
  parse queue being empty. Since the queue is empty, the testfile
  is never scheduled to be parsed again, and the unresolved identifier
  stays.

REPOSITORY
  R52 KDevelop: PHP Support

BRANCH
  multi

REVISION DETAIL
  https://phabricator.kde.org/D14113

AFFECTED FILES
  duchain/tests/duchain_multiplefiles.cpp
  phpparsejob.cpp

To: pprkut
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180714/cb6356bb/attachment.html>