D10496: Template for C, with CMake

[Friedrich W. H. Kossebau]

kossebau added a comment.


  +1

INLINE COMMENTS

> CMakeLists.txt:1
> +cmake_minimum_required(VERSION 3.10)
> +

This being a template, better use a lower number here, like 3.0
Nothing in the template requires that current version 3.10, so no need to be that demanding  by default((e.g. KDevelop's code also still only requires 3.0 :) ).

> cmake_plainc.kdevtemplate:4
> +Name=CMake C
> +Name[bs]=CMake C
> +Name[ca]=CMake C

All the translations can be removed.

KDE's automated translation system has a separate database with all the translations, which is filled directly by the translators with translations (actually pp files in a svn repo).
Once per day (actually CET night) a script runs over the sources and pulls all strings which need to be translated, and pushes back translations that are stored in-source like in this kdevtemplate file. And anything which is not in the database will be removed.

So once this is in, and due to the original strings not yet extracted into the database and thus no translations existing, all the translations here will be removed on the first run of the script. So no need to have them here from the start.

Just keep the 
'''
Name=CMake C
'''
line.

> cmake_plainc.kdevtemplate:37
> +Comment=Simple CMake-based C application
> +Comment[bs]=Jednostavna na CMake bazirana C aplikacija
> +Comment[ca]=Senzilla aplicació C basada en CMake

Same as for Name translations. Just keep the

  Comment=Simple CMake-based C application

line.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D10496

To: windblows
Cc: kossebau, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180214/19bb2049/attachment.html>