<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10496" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>+1</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10496#inline-49592" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">cmake_minimum_required(VERSION 3.10)
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This being a template, better use a lower number here, like 3.0<br />
Nothing in the template requires that current version 3.10, so no need to be that demanding by default((e.g. KDevelop's code also still only requires 3.0 :) ).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10496#inline-49598" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cmake_plainc.kdevtemplate:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name=CMake C
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name[bs]=CMake C
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name[ca]=CMake C
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">All the translations can be removed.</p>
<p style="padding: 0; margin: 8px;">KDE's automated translation system has a separate database with all the translations, which is filled directly by the translators with translations (actually pp files in a svn repo).<br />
Once per day (actually CET night) a script runs over the sources and pulls all strings which need to be translated, and pushes back translations that are stored in-source like in this kdevtemplate file. And anything which is not in the database will be removed.</p>
<p style="padding: 0; margin: 8px;">So once this is in, and due to the original strings not yet extracted into the database and thus no translations existing, all the translations here will be removed on the first run of the script. So no need to have them here from the start.</p>
<p style="padding: 0; margin: 8px;">Just keep the <br />
'''<br />
Name=CMake C<br />
'''<br />
line.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10496#inline-49600" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cmake_plainc.kdevtemplate:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Comment=Simple CMake-based C application
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Comment[bs]=Jednostavna na CMake bazirana C aplikacija
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Comment[ca]=Senzilla aplicació C basada en CMake
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same as for Name translations. Just keep the</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Comment=Simple CMake-based C application</pre></div>
<p style="padding: 0; margin: 8px;">line.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10496" rel="noreferrer">https://phabricator.kde.org/D10496</a></div></div><br /><div><strong>To: </strong>windblows<br /><strong>Cc: </strong>kossebau, apol, kdevelop-devel<br /></div>