D17858: clang: Also detect Clang builtin dirs at runtime on Unix

[René J.V. Bertin]

rjvbb added a comment.


  >   Users shouldn't change the dependencies and expect things to work without a rebuild.
  
  That is not at all the idea behind this patch. The goal is that you can apply minor compiler updates without having to rebuild.
  The modification only allows very specific changes to the install location, which should arise only as the result of a clang update.
  
  I invite you to research the code to see for yourself where the string we're discussing here is used: only in a single location where libclang has to be told where to find its own private headers. I don't even have words for the idea that it could be normal or acceptable to require the rebuild of something as large as KDevelop is a single character changes in that one sad string. Yes, I know about ccache and other optimisations those of us who build KDevelop from source at least once a week can exploit. That's irrelevant for all the package maintainers of all the distributions out there who'd like to ship KDevelop with an up-to-date libclang (and probably the system copy) ... and the bandwidth used to download all those copies of the rebuilt packages.
  
  The concern that the path format could change is legitimate but unless we already know that and how it will I'd say let's take that bridge when we get to it. Either way we'll most likely end up using the hardcoded string in that case because the chance that my patch serves up an inappropriate but existing path if the format changes must be homeopatically slim.
  
  The env. variable that allows to override the builtin path can wreak much more havoc, maybe it should be removed too if you're so concerned about experimenting users and randomness?!

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17858

To: rjvbb, #kdevelop, flherne
Cc: flherne, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181229/cd0461f4/attachment-0001.html>