D17278: Meson plugin: First working version

Daniel Mensinger noreply at phabricator.kde.org
Sat Dec 1 15:11:40 GMT 2018

dmensinger marked 6 inline comments as done.
dmensinger added inline comments.


> rizzitello wrote in mesonimportjob.cpp:47
> "sourcePath" and "bulilddir" appear to be unused here.

Yeah, I haven't touched that code yet. This is still from the barebones framework that was created over a year ago. I will replace this function with a stub for the time being.

> rizzitello wrote in mesonconfigpage.cpp:178
> auto

I don't know why you would use `auto` here. Should I use `auto` for every dynamic_cast?

  R32 KDevelop


To: dmensinger, apol
Cc: rizzitello, yurchor, kde-doc-english, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181201/e115dff3/attachment-0001.html>

More information about the KDevelop-devel mailing list