D17278: Meson plugin: First working version

[Chris Rizzitello]

rizzitello added inline comments.

INLINE COMMENTS

> mesonbuilder.cpp:55
> +
> +        output->appendLine(i18n("    *** MESON ERROR ***"));
> +        output->appendLine(QStringLiteral(""));

Would ending the string with a \n (or two) remove the need to append an empty QStringLiteral in the next line?

> mesonbuilder.cpp:57
> +        output->appendLine(QStringLiteral(""));
> +        QStringList lines = m_error.split(QChar((int)'\n'));
> +        output->appendLines(lines);

QChar::fromLatin1('\n') instead of the older cast ?

> mesonbuilder.cpp:184
> +        return realJob;
> +    } else {
> +        QList<KJob*> jobs = {

Else is not needed since the if ends with a return.

> mesonconfig.cpp:184
> +{
> +    if (buildDir.isEmpty() || mesonExecutable.isEmpty() || buildType.isEmpty()) {
> +        return false;

`return !( buildDir.isEmpty() || mesonExecutable.isEmpty() || buildType.isEmpty() );` ?

> mesonimportjob.cpp:47
> +// TODO: probably want to process the object in this function (e.g. see CMakeImportJsonJob)
> +QJsonObject import(const Path& commandsFile, const Path& sourcePath, const Path& builddir)
> +{

"sourcePath" and "bulilddir" appear to be unused here.

> mesonconfigpage.cpp:178
> +    qCDebug(KDEV_Meson) << "Adding build directory";
> +    MesonManager* mgr = dynamic_cast<MesonManager*>(m_project->buildSystemManager());
> +    MesonBuilder* bld = dynamic_cast<MesonBuilder*>(mgr->builder());

auto

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17278

To: dmensinger, apol
Cc: rizzitello, yurchor, kde-doc-english, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181201/e992d1f3/attachment.html>