D14931: Eliminate duplicate QMaps in OutputWidget
noreply at phabricator.kde.org
Thu Aug 23 08:00:47 BST 2018
kfunk added inline comments.
> + QString filter;
> + void destroy();
> + };
If I'm not mistaken you could omit the `destroy()` function (and probably a few other `delete`s) completely by making the two pointers in the struct a `QSharedPointer`. I think this would make the code a little bit more clean.
What do you think?
To: vkorneev, #kdevelop
Cc: kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel