D14931: Eliminate duplicate QMaps in OutputWidget

Kevin Funk noreply at phabricator.kde.org
Thu Aug 23 08:00:47 BST 2018


kfunk added inline comments.

INLINE COMMENTS

> outputwidget.h:108
> +        QString filter;
> +        void destroy();
> +    };

If I'm not mistaken you could omit the `destroy()` function (and probably a few other `delete`s)  completely by making the two pointers in the struct a `QSharedPointer`. I think this would make the code a little bit more clean.

What do you think?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14931

To: vkorneev, #kdevelop
Cc: kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180823/7778fc19/attachment.html>


More information about the KDevelop-devel mailing list