D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else.
noreply at phabricator.kde.org
Wed Aug 22 10:29:37 BST 2018
kfunk added inline comments.
> volden wrote in test_perforce.cpp:58
> On Second thought. It does remove the need for one of the defines.
Scanning recursively through the build dir seems pretty unclean to me.
Wouldn't a simple `QStandardPaths::findExecutable("p4clientstub", P4_BINARY_DIR);` with `P4_BINARY_DIR` initialized with `CMAKE_RUNTIME_OUTPUT_DIRECTORY` work?
To: volden, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel