D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else.

[Kevin Funk]

kfunk added inline comments.

INLINE COMMENTS

> volden wrote in test_perforce.cpp:58
> On Second thought. It does remove the need for one of the defines.

Scanning recursively through the build dir seems pretty unclean to me.

Wouldn't a simple `QStandardPaths::findExecutable("p4clientstub", P4_BINARY_DIR);` with `P4_BINARY_DIR` initialized with `CMAKE_RUNTIME_OUTPUT_DIRECTORY` work?

See: https://cmake.org/cmake/help/v3.9/variable/CMAKE_RUNTIME_OUTPUT_DIRECTORY.html

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14958

To: volden, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180822/6b3af5d8/attachment.html>