<table><tr><td style="">kfunk added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14958">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14958#inline-79951">View Inline</a><span style="color: #4b4d51; font-weight: bold;">volden</span> wrote in <span style="color: #4b4d51; font-weight: bold;">test_perforce.cpp:58</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">On Second thought. It does remove the need for one of the defines.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Scanning recursively through the build dir seems pretty unclean to me.</p>

<p style="padding: 0; margin: 8px;">Wouldn't a simple <tt style="background: #ebebeb; font-size: 13px;">QStandardPaths::findExecutable("p4clientstub", P4_BINARY_DIR);</tt> with <tt style="background: #ebebeb; font-size: 13px;">P4_BINARY_DIR</tt> initialized with <tt style="background: #ebebeb; font-size: 13px;">CMAKE_RUNTIME_OUTPUT_DIRECTORY</tt> work?</p>

<p style="padding: 0; margin: 8px;">See: <a href="https://cmake.org/cmake/help/v3.9/variable/CMAKE_RUNTIME_OUTPUT_DIRECTORY.html" class="remarkup-link" target="_blank" rel="noreferrer">https://cmake.org/cmake/help/v3.9/variable/CMAKE_RUNTIME_OUTPUT_DIRECTORY.html</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14958">https://phabricator.kde.org/D14958</a></div></div><br /><div><strong>To: </strong>volden, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>