D14931: Eliminate duplicate QMaps in OutputWidget

Vyacheslav Korneev noreply at phabricator.kde.org
Sun Aug 19 22:11:00 BST 2018


vkorneev added inline comments.

INLINE COMMENTS

> pino wrote in outputwidget.h:110
> I'd personally name it `findFilteredView()`, and make it `const`, and return a `const_iterator`. At least from a quick glance, it seems like the iterator returned is always not changed/removed.

I was thinking about returning the const_iterator, but the returned value is changed at least in OutputWidget::outputFilter() (lines 658 and 663).

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14931

To: vkorneev
Cc: pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180819/f45ef3d7/attachment-0001.html>


More information about the KDevelop-devel mailing list