D14931: Eliminate duplicate QMaps in OutputWidget
Vyacheslav Korneev
noreply at phabricator.kde.org
Sun Aug 19 22:07:02 BST 2018
vkorneev updated this revision to Diff 40016.
vkorneev added a comment.
Multiple improvements corresponding to review comments
Use QHash instead of QMap
Rename getFilteredView() to findFilteredView()
Remove filtered view in one lookup
Don't compare pointers to nullptr before delete in FilteredView::destroy()
REPOSITORY
R32 KDevelop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14931?vs=40009&id=40016
BRANCH
refactor_outputwidget (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D14931
AFFECTED FILES
plugins/standardoutputview/outputwidget.cpp
plugins/standardoutputview/outputwidget.h
plugins/standardoutputview/tests/test_standardoutputview.cpp
To: vkorneev
Cc: pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180819/f59df07c/attachment.html>
More information about the KDevelop-devel
mailing list