D14929: Default to QT_NO_CAST_FROM_ASCII/QT_NO_CAST_TO_ASCII/QT_NO_CAST_FROM_BYTEARRAY

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Aug 19 15:33:18 BST 2018


kossebau added a comment.


  There have been lots of commits across the whole codebase of all the plugins to use QLatin1String, QStringLiteral & Co. 
  Though the usage is not consistent, which leaves developer editing the code puzzled what to use.
  
  Given that kdevelop is resource-heavy, default to the explicit classes with papercut-like performance  effects might make sense in general, despite the more complex code to read for humans.
  
  All plugins not yet building with the strict settings explicitly have to opt out, and would/could be ported one-by-one to follow the strict settings.
  
  Test code should be always fine to not avoid the implicit conversions, so opt-out there  would be always added.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14929

To: kossebau, #kdevelop
Cc: kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180819/15590aef/attachment.html>


More information about the KDevelop-devel mailing list