D14789: Ignore file size limit for internal data files.

[Sven Brauch]

brauch requested changes to this revision.
brauch added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> parsejob.cpp:279
> +            foreach (const QString path, paths) {
> +                if (fileInfo.absolutePath().startsWith(path + QStringLiteral("/kdev"))) {
> +                    qCInfo(LANGUAGE) << "Found internal file " << fileInfo.absoluteFilePath() << " in " << path << ". Ignoring file size limit!";

I think you need to compare two canonical paths here, not this. This will break if there are symlinks in the path(s), or something changes about leading or trailing slashes, or e.g. when the user configures his XDG_DATA_DIRS with ../ segments in it or whatever ...

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14789

To: pprkut, brauch
Cc: brauch, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180813/f617160a/attachment.html>