<table><tr><td style="">brauch requested changes to this revision.<br />brauch added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14789">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14789#inline-78340">View Inline</a><span style="color: #4b4d51; font-weight: bold;">parsejob.cpp:279</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">path</span><span class="p">,</span> <span class="n">paths</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">fileInfo</span><span class="p">.</span><span class="n">absolutePath</span><span class="p">().</span><span class="n">startsWith</span><span class="p">(</span><span class="n">path</span> <span style="color: #aa2211">+</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"/kdev"</span><span class="p">)))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">qCInfo</span><span class="p">(</span><span class="n">LANGUAGE</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Found internal file "</span> <span style="color: #aa2211"><<</span> <span class="n">fileInfo</span><span class="p">.</span><span class="n">absoluteFilePath</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">" in "</span> <span style="color: #aa2211"><<</span> <span class="n">path</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">". Ignoring file size limit!"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think you need to compare two canonical paths here, not this. This will break if there are symlinks in the path(s), or something changes about leading or trailing slashes, or e.g. when the user configures his XDG_DATA_DIRS with ../ segments in it or whatever ...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14789">https://phabricator.kde.org/D14789</a></div></div><br /><div><strong>To: </strong>pprkut, brauch<br /><strong>Cc: </strong>brauch, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>