D7865: Bring back per-project setting of the cmake executable completely

[René J.V. Bertin]

rjvbb created this revision.
rjvbb added reviewers: apol, volden.
rjvbb added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  This is a follow-up and partial reimplementation of https://phabricator.kde.org/D7762, targeting the 5.2 branch. It brings back everything https://phabricator.kde.org/R32:b9a746480f11b310b0c6e9a3e3d9ab795874b695 removed while keeping the notion of a kdevelop-wide custom CMake setting.
  
  I have made a beginning with the transition to using `CMake Executable` instead of `CMake Binary` in the project settings file. Doing this properly means to me maintaining backwards compatibility for a reasonable transition period, which includes saving both the old and new keys at least until 5.2 is released.
  
  I've not taken over the `Old::oldcmakeExecutableKey` key from https://phabricator.kde.org/D7762 as it appears not to be used, and have also stuck with my original `currentCMakeExecutable` instead of `currentCmakeExecutable` for consistency with the spelling of other variables. The fallback to the KDev-wide CMake setting is also implemented in that function, which makes it trivial to use the project's own cmake during the import in the `CMakeServer` ctor.

TEST PLAN
  Works as intended on Mac and Linux.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7865

AFFECTED FILES
  plugins/cmake/cmakebuilddirchooser.cpp
  plugins/cmake/cmakebuilddirchooser.h
  plugins/cmake/cmakebuilddirchooser.ui
  plugins/cmake/cmakeserver.cpp
  plugins/cmake/cmakeutils.cpp
  plugins/cmake/cmakeutils.h
  plugins/cmake/settings/cmakepreferences.cpp
  plugins/cmake/tests/testhelpers.h
  plugins/cmakebuilder/cmakejob.cpp

To: rjvbb, apol, volden
Cc: kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170917/0ee51480/attachment-0001.html>