<table><tr><td style="">rjvbb created this revision.<br />rjvbb added reviewers: apol, volden.<br />rjvbb added a project: KDevelop.<br />Restricted Application added a subscriber: kdevelop-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7865" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This is a follow-up and partial reimplementation of <a href="https://phabricator.kde.org/D7762" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel="noreferrer">D7762</a>, targeting the 5.2 branch. It brings back everything <a href="https://phabricator.kde.org/R32:b9a746480f11b310b0c6e9a3e3d9ab795874b695" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">b9a746480f11b310b0c6e9a3e3d9ab795874b695</a> removed while keeping the notion of a kdevelop-wide custom CMake setting.</p>

<p>I have made a beginning with the transition to using <tt style="background: #ebebeb; font-size: 13px;">CMake Executable</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">CMake Binary</tt> in the project settings file. Doing this properly means to me maintaining backwards compatibility for a reasonable transition period, which includes saving both the old and new keys at least until 5.2 is released.</p>

<p>I've not taken over the <tt style="background: #ebebeb; font-size: 13px;">Old::oldcmakeExecutableKey</tt> key from <a href="https://phabricator.kde.org/D7762" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel="noreferrer">D7762</a> as it appears not to be used, and have also stuck with my original <tt style="background: #ebebeb; font-size: 13px;">currentCMakeExecutable</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">currentCmakeExecutable</tt> for consistency with the spelling of other variables. The fallback to the KDev-wide CMake setting is also implemented in that function, which makes it trivial to use the project's own cmake during the import in the <tt style="background: #ebebeb; font-size: 13px;">CMakeServer</tt> ctor.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Works as intended on Mac and Linux.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7865" rel="noreferrer">https://phabricator.kde.org/D7865</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/cmake/cmakebuilddirchooser.cpp<br />
plugins/cmake/cmakebuilddirchooser.h<br />
plugins/cmake/cmakebuilddirchooser.ui<br />
plugins/cmake/cmakeserver.cpp<br />
plugins/cmake/cmakeutils.cpp<br />
plugins/cmake/cmakeutils.h<br />
plugins/cmake/settings/cmakepreferences.cpp<br />
plugins/cmake/tests/testhelpers.h<br />
plugins/cmakebuilder/cmakejob.cpp</div></div></div><br /><div><strong>To: </strong>rjvbb, apol, volden<br /><strong>Cc: </strong>kdevelop-devel, KDevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>