D8555: Fixed launch url composition from launch configuration server, path and arguments

[Aleix Pol Gonzalez]

apol added a comment.


  Please check your editor configuration, the indentation looks off on your patch.

INLINE COMMENTS

> executebrowserplugin.cpp:68
>  {
> -    QUrl url;
> -
> +       QUrl url;
>      if( !cfg )

Typo?

> executebrowserplugin.cpp:84
> +       QString path(grp.readEntry( ExecuteBrowserPlugin::pathEntry, "" ));
> +    if( !(host.endsWith("/")) && !(path.startsWith("/")) ) {
> +               host += "/";

Why do you want it to end with /?

REPOSITORY
  R67 KDevelop Execute Browser

REVISION DETAIL
  https://phabricator.kde.org/D8555

To: santilin
Cc: apol, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171030/d18145fe/attachment.html>