D8512: kdevplatform: less auto-casting from/to ascii & from bytearray

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Oct 27 09:28:51 UTC 2017

kossebau marked an inline comment as done.
kossebau added a comment.

  So as discussed on irc, will not discard this then, but see to turn this into something all maintainers agree on (and see how to get stringhelper.cpp solved)
  Will prepare next some Best Practices Rules for qt string handling code (whether using QStringLiteral or QLatin1String in qstringbuilder-powered concatenations, how to avoid .data duplication when using same qstringliterals, etc) to put in some CODING,md file, so we have some golden rules around which should help to reduce the current random approaches. If good enough perhaps also could be moved to kde wikis for shared usage.


> kfunk wrote in CMakeLists.txt:1
> Is this needed? Isn't it set by the parent CMakeLists.txt?

Good catch. Forgot to remove again, left-over from incrementally extending setting those defs.

  R32 KDevelop


To: kossebau
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171027/b6a3f90a/attachment.html>

More information about the KDevelop-devel mailing list