D8512: kdevplatform: less auto-casting from/to ascii & from bytearray
Kevin Funk
noreply at phabricator.kde.org
Fri Oct 27 08:34:24 UTC 2017
kfunk added a comment.
LGTM (only had a relatively quick look)
INLINE COMMENTS
> CMakeLists.txt:1
> +add_definitions(
> + -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII -DQT_NO_CAST_FROM_BYTEARRAY
Is this needed? Isn't it set by the parent CMakeLists.txt?
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D8512
To: kossebau
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171027/e5213448/attachment.html>
More information about the KDevelop-devel
mailing list