D8156: Fix registration of the enabled state of plugins

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> kossebau wrote in test_pluginenabling.cpp:45
> > when plugincontroller is instantiated.
> 
> Which especially means a new session created, without any config yet stored.
> 
> Or did you mean to move the TestCore::initialize() & TestCore::shutdown() out of the init and cleanup methods and instead use them directly in the test functions, with different session arguments?
> Hm... seems no other code does it. Though the API dox hints one might be able to use it more than once, and the current implementation on a first view does also not advise against it. So, shall I give that a try?

Yes, that was what I had in mind. Just init + shutdown the TestCore within the tests. What might be tricky is shutting down the AutoTestShell, not sure that's supported yet. That said, maybe you should push this as-is and we can clean it up in the future (i.e., probably never). But it's not too bad to hold up your overall change, I guess.

> kossebau wrote in test_pluginenabling.cpp:61
> Was copied over from some other test. Shall I then clean up the other tests as well from empty methods?

Yes, in separate patches though.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8156

To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171009/4fe7399e/attachment.html>