D8202: Fix Qt 5.5 compatibility -- no constFirst/Last methods.

Mikołaj Płomieński noreply at phabricator.kde.org
Sun Oct 8 19:10:48 UTC 2017

blaze added a comment.

  In https://phabricator.kde.org/D8202#153340, @kossebau wrote:
  > > None of these are in performance-relevant code, so I don't believe it's worthwhile adding ifdefs; just revert this patch whenever 5.5 support is dropped.
  > Possible problems: the person bumping min qt version to > 5.5 will not remember about this. And the same for the next person "fixing" this non-const calls.
  > So while ifdef adds some another code variant which makes test coverage worse, it still help cleaning up the code on version bumps and prevents compat-breaking "fixing". So I would opt for ifdef.
  First issue can be solved by adding a task to a job list for the certain milestone where Qt5.5 support should be dropped, not sure if such list even exists but still. Second is more simple: just comment the code that needs special attention. Not a rock-solid solution but still a possibility of having cleaner code yet being able to manage this stuff at some point in the future.

  R32 KDevelop


To: flherne, #kdevelop, mwolff
Cc: blaze, kfunk, mwolff, kossebau, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171008/f01dc79a/attachment.html>

More information about the KDevelop-devel mailing list