D8202: Fix Qt 5.5 compatibility -- no constFirst/Last methods.
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Sun Oct 8 15:58:22 UTC 2017
kossebau added a comment.
> None of these are in performance-relevant code, so I don't believe it's worthwhile adding ifdefs; just revert this patch whenever 5.5 support is dropped.
Possible problems: the person bumping min qt version to > 5.5 will not remember about this. And the same for the next person "fixing" this non-const calls.
So while ifdef adds some another code variant which makes test coverage worse, it still help cleaning up the code on version bumps and prevents compat-breaking "fixing". So I would opt for ifdef.
To: flherne, #kdevelop
Cc: kossebau, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel