D7930: Kdevelop CMake plugin : use canonical paths to build.dir

René J.V. Bertin noreply at phabricator.kde.org
Mon Oct 2 13:08:36 UTC 2017


rjvbb updated this revision to Diff 20244.
rjvbb added a comment.


  Don't use QFileInfo::toCanonicalFilePath() without checking first if the file/folder exists.
  Without this check, opening a project after trashing its build dir will cause the initial cmake configuration dialog to open instead of rebuilding the build dir silently.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7930?vs=19767&id=20244

REVISION DETAIL
  https://phabricator.kde.org/D7930

AFFECTED FILES
  plugins/cmake/cmakecommitchangesjob.cpp
  plugins/cmake/cmakeimportjsonjob.cpp
  plugins/cmake/cmakemanager.cpp
  plugins/cmake/cmakemodelitems.cpp
  plugins/cmake/cmakeserverimportjob.cpp
  plugins/cmake/cmakeutils.cpp
  plugins/cmake/cmakeutils.h
  plugins/cmake/settings/cmakepreferences.cpp

To: rjvbb, #kdevelop, apol
Cc: flherne, mwolff, apol, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171002/a176d28f/attachment.html>


More information about the KDevelop-devel mailing list