<table><tr><td style="">rjvbb updated this revision to Diff 20244.<br />rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7930" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Don't use QFileInfo::toCanonicalFilePath() without checking first if the file/folder exists.<br />
Without this check, opening a project after trashing its build dir will cause the initial cmake configuration dialog to open instead of rebuilding the build dir silently.</p></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D7930?vs=19767&id=20244" rel="noreferrer">https://phabricator.kde.org/D7930?vs=19767&id=20244</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7930" rel="noreferrer">https://phabricator.kde.org/D7930</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/cmake/cmakecommitchangesjob.cpp<br />
plugins/cmake/cmakeimportjsonjob.cpp<br />
plugins/cmake/cmakemanager.cpp<br />
plugins/cmake/cmakemodelitems.cpp<br />
plugins/cmake/cmakeserverimportjob.cpp<br />
plugins/cmake/cmakeutils.cpp<br />
plugins/cmake/cmakeutils.h<br />
plugins/cmake/settings/cmakepreferences.cpp</div></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, apol<br /><strong>Cc: </strong>flherne, mwolff, apol, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>