D8634: Custom defines/includes: Improve handling of parser arguments

[Aaron Puchert]

aaronpuchert updated this revision to Diff 22980.
aaronpuchert marked 9 inline comments as done.
aaronpuchert added a comment.


  Incorporated review by Milian:
  
  - Used array instead of single named members for parser arguments.
  - Replaced get() and set() by operator[].
  - Added default arguments for Objective C to make sure isAnyEmpty still works as intended.

REPOSITORY
  R32 KDevelop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8634?vs=21821&id=22980

BRANCH
  parser-arguments

REVISION DETAIL
  https://phabricator.kde.org/D8634

AFFECTED FILES
  plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
  plugins/custom-definesandincludes/compilerprovider/icompiler.h
  plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
  plugins/custom-definesandincludes/compilerprovider/settingsmanager.h
  plugins/custom-definesandincludes/definesandincludesmanager.cpp
  plugins/custom-definesandincludes/kcm_widget/parserwidget.cpp
  plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.cpp

To: aaronpuchert, #kdevelop, apol
Cc: apol, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171127/daef8151/attachment.html>