<table><tr><td style="">aaronpuchert updated this revision to Diff 22980.<br />aaronpuchert marked 9 inline comments as done.<br />aaronpuchert added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8634" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Incorporated review by Milian:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Used array instead of single named members for parser arguments.</li>
<li class="remarkup-list-item">Replaced get() and set() by operator[].</li>
<li class="remarkup-list-item">Added default arguments for Objective C to make sure isAnyEmpty still works as intended.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D8634?vs=21821&id=22980" rel="noreferrer">https://phabricator.kde.org/D8634?vs=21821&id=22980</a></div></div><br /><div><strong>BRANCH</strong><div><div>parser-arguments</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8634" rel="noreferrer">https://phabricator.kde.org/D8634</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp<br />
plugins/custom-definesandincludes/compilerprovider/icompiler.h<br />
plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp<br />
plugins/custom-definesandincludes/compilerprovider/settingsmanager.h<br />
plugins/custom-definesandincludes/definesandincludesmanager.cpp<br />
plugins/custom-definesandincludes/kcm_widget/parserwidget.cpp<br />
plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.cpp</div></div></div><br /><div><strong>To: </strong>aaronpuchert, KDevelop, apol<br /><strong>Cc: </strong>apol, mwolff, kdevelop-devel<br /></div>