D8953: Make VcsLocation also implicitly shared
noreply at phabricator.kde.org
Fri Nov 24 01:54:17 UTC 2017
aaronpuchert added a comment.
It is indeed a mystery. Note that the member function isn't marked `const`, which it probably should be. Adding the `const` specifier produces a compiler error (about ambiguous function calls), as it should.
I think that either the method or the standalone function should go away, but which one? Right now the standalone function is used for the `QHash<VcsLocation,QByteArray>` members in `VcsDiffPrivate`, the method doesn't seem to be used at all. (Removing the implementation doesn't produce linker errors for me.) However, the implementation of the member `operator==` looks "more correct."
To: kossebau, #kdevelop
Cc: aaronpuchert, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel