D8953: Make VcsLocation also implicitly shared

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In https://phabricator.kde.org/D8953#171062, @mwolff wrote:
  
  > what mystery? can you give more details?
  
  
  There are two `operator==()` methods, one non-member and one non-const member one, which check different properties:
  
    inline bool operator==( const KDevelop::VcsLocation& lhs, const KDevelop::VcsLocation& rhs )
    {
        return( lhs.type() == rhs.type()
                && lhs.repositoryServer() == rhs.repositoryServer()
                && lhs.localUrl() == rhs.localUrl() );
    }
  
  and
  
    bool VcsLocation::operator==( const KDevelop::VcsLocation& rhs )
    {
        return( type() == rhs.type()
                && repositoryServer() == rhs.repositoryServer()
                && localUrl() == rhs.localUrl()
                && repositoryPath() == rhs.repositoryPath()
                && repositoryModule() == rhs.repositoryModule()
                && repositoryBranch() == rhs.repositoryBranch()
                && repositoryTag() == rhs.repositoryTag()
                && userData() == rhs.userData() );
    }
  
  They exist since their initial commit in 2007, but only the latter has been adapted on new property additions.
  
  I cannot see why both exist and why with different logic.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8953

To: kossebau, #kdevelop
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171123/d0e862aa/attachment.html>