D8913: compute itemrepository version from version plus KDEVELOP_VERSION

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.


  LGTM in general.

INLINE COMMENTS

> config-kdevplatform.h.cmake:6
> +
> +#define KDEV_ITEMREPOSITORY_VERSION (KDEVELOP_VERSION_MAJOR << 24) \
> +                                  + (KDEVELOP_VERSION_MINOR << 16) \

Maybe rename the CMake var `KDEV_ITEMREPOSITORY_VERSION` to something like `KDEV_ITEMREPOSITORY_INCREMENT` to not overlap with the C++ define name and meaning?

Also reset `KDEV_ITEMREPOSITORY_INCREMENT` to 0.

> itemrepositoryregistry.cpp:77
>    if (!dir.exists(QStringLiteral("version_%1").arg(staticItemRepositoryVersion()))) {
> -    qCWarning(SERIALIZATION) << "version-hint not found, seems to be an old version";
> +    qCWarning(SERIALIZATION) << "version mismatch or no version hint";
>      return true;

Could probably print the `staticItemRepositoryVersion()`, too.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8913

To: brauch, #kdevelop, kfunk, mwolff, flherne
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171120/33968173/attachment.html>