<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8913" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>LGTM in general.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8913#inline-39696" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config-kdevplatform.h.cmake:6</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">#define KDEV_ITEMREPOSITORY_VERSION (KDEVELOP_VERSION_MAJOR << 24) \</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                  <span class="err">+</span> <span class="err">(KDEVELOP_VERSION_MINOR</span> <span class="err"><<</span> <span class="err">16)</span> <span class="err">\</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe rename the CMake var <tt style="background: #ebebeb; font-size: 13px;">KDEV_ITEMREPOSITORY_VERSION</tt> to something like <tt style="background: #ebebeb; font-size: 13px;">KDEV_ITEMREPOSITORY_INCREMENT</tt> to not overlap with the C++ define name and meaning?</p>

<p style="padding: 0; margin: 8px;">Also reset <tt style="background: #ebebeb; font-size: 13px;">KDEV_ITEMREPOSITORY_INCREMENT</tt> to 0.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8913#inline-39692" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">itemrepositoryregistry.cpp:77</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">dir</span><span class="p">.</span><span class="n">exists</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"version_%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">staticItemRepositoryVersion</span><span class="p">())))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">qCWarning</span><span class="p">(</span><span class="n">SERIALIZATION</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"version<span class="bright">-hint not found, seems to be an old</span> version"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qCWarning</span><span class="p">(</span><span class="n">SERIALIZATION</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"version<span class="bright"> mismatch or no</span> version<span class="bright"> hint</span>"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">return</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could probably print the <tt style="background: #ebebeb; font-size: 13px;">staticItemRepositoryVersion()</tt>, too.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8913" rel="noreferrer">https://phabricator.kde.org/D8913</a></div></div><br /><div><strong>To: </strong>brauch, KDevelop, kfunk, mwolff, flherne<br /><strong>Cc: </strong>kdevelop-devel<br /></div>