D8492: Make SourceFormatter plugins enablable, hide actions with no plugins

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> kdevastyle.json:31
>          "Description[zh_CN]": "一个根据指定规则设定格式化源代码的插件",
> -        "Icon": "kdevelop",
> +        "Icon": "text-field",
>          "Id": "kdevastyle",

unrelated?

> kdevcustomscript.json:31
>          "Description[zh_CN]": "使用自定义脚本格式化 C 文件的插件",
> -        "Icon": "kdevelop",
> +        "Icon": "text-field",
>          "Id": "kdevcustomscript",

unrelated? different patch?

> sourceformatterplugin.cpp:43
>  {
> -    return 1;
> +    // exception of accessing internal API, to be solved by making sourceFormatterController a plugin
> +    const auto hasFormatters = KDevelop::Core::self()->sourceFormatterControllerInternal()->hasFormatters();

why not simply make hasFormatters public, i.e. add it to the sourceFormatterController API?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8492

To: kossebau, #kdevelop, kfunk
Cc: mwolff, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171119/01f2dd8b/attachment-0001.html>