<table><tr><td style="">mwolff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8492" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8492#inline-39574" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevastyle.json:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #766510">"Description[zh_CN]"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"一个根据指定规则设定格式化源代码的插件"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #766510">"Icon"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"<span class="bright">kdevelop</span>"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #766510">"Icon"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"<span class="bright">text-field</span>"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #766510">"Id"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"kdevastyle"</span><span style="color: #aa2211">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8492#inline-39575" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevcustomscript.json:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #766510">"Description[zh_CN]"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"使用自定义脚本格式化 C 文件的插件"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #766510">"Icon"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"<span class="bright">kdevelop</span>"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #766510">"Icon"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"<span class="bright">text-field</span>"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #766510">"Id"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"kdevcustomscript"</span><span style="color: #aa2211">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated? different patch?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8492#inline-39572" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sourceformatterplugin.cpp:43</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #74777d"><span class="bright">// exception of accessing internal API, to be solved by making sourceFormatterController a plugin</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">hasFormatters</span> <span style="color: #aa2211">=</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">Core</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">sourceFormatterControllerInternal</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">hasFormatters</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why not simply make hasFormatters public, i.e. add it to the sourceFormatterController API?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8492" rel="noreferrer">https://phabricator.kde.org/D8492</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop, kfunk<br /><strong>Cc: </strong>mwolff, kfunk, kdevelop-devel<br /></div>