D8907: Suspend the background parser during Core initialization
noreply at phabricator.kde.org
Sun Nov 19 18:46:09 UTC 2017
mwolff added inline comments.
> brauch wrote in core.cpp:248
> no need for the .data(), is there?
true, I'll fix this up everywhere in a separate patch
> brauch wrote in projectcontroller.cpp:663
> if you use Q_SIGNALS it would be consequent to use Q_EMIT ;)
afaik we only require that for our headers, but not for the .cpp? the header also uses Q_SLOTS btw
To: mwolff, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel