D8907: Suspend the background parser during Core initialization

Milian Wolff noreply at phabricator.kde.org
Sun Nov 19 18:46:09 UTC 2017


mwolff added inline comments.

INLINE COMMENTS

> brauch wrote in core.cpp:248
> no need for the .data(), is there?

true, I'll fix this up everywhere in a separate patch

> brauch wrote in projectcontroller.cpp:663
> if you use Q_SIGNALS it would be consequent to use Q_EMIT ;)

afaik we only require that for our headers, but not for the .cpp? the header also uses Q_SLOTS btw

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8907

To: mwolff, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171119/0403b78c/attachment.html>


More information about the KDevelop-devel mailing list