D8907: Suspend the background parser during Core initialization
Sven Brauch
noreply at phabricator.kde.org
Sun Nov 19 18:06:38 UTC 2017
brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.
Makes sense to me. Thanks for working on this issue!
INLINE COMMENTS
> core.cpp:248
> + m_core, [this]() {
> + languageController.data()->backgroundParser()->resume();
> + });
no need for the .data(), is there?
> projectcontroller.cpp:663
> + openProjects(projects);
> + emit initialized();
> + });
if you use Q_SIGNALS it would be consequent to use Q_EMIT ;)
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D8907
To: mwolff, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171119/36e20255/attachment-0001.html>
More information about the KDevelop-devel
mailing list